shwstppr commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support URL: https://github.com/apache/cloudstack/pull/3731#discussion_r361088492
########## File path: server/src/main/java/com/cloud/template/TemplateManagerImpl.java ########## @@ -2247,7 +2247,7 @@ private void updateTemplate(long templateId, String fileExtension, long zoneId, } private void updateDirectDownloadTemplate(long templateId, long zoneId) { - TemplateDataStoreVO templateStore = _tmplStoreDao.findByTemplateZone(templateId, zoneId, DataStoreRole.Image); + TemplateDataStoreVO templateStore = _tmplStoreDao.findByTemplate(templateId, DataStoreRole.Image); Review comment: @nvazquez as we do not store `store_id` in `cloud.template_store_ref` table for direct download template, we cannot find the entry in the table for a zone while update. Continued with same behaviour from user direct download templates. Do we need to change this for system direct download templates? `updateDirectDownloadTemplate` is new method added in this PR only ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services