rakgenius opened a new pull request #3790: Bug fix: Dont display empty item in 
free ip list
URL: https://github.com/apache/cloudstack/pull/3790
 
 
   ## Description
   Remove the empty item from the free IP list when we click on "Acquire New 
IP" in the networks section.
   If we dont select any IP address from the list and click ok, it sends 
"ipaddress=-1" as the parameter which is not back compatible.
   
   This fix ensures that no empty item is displayed and by default one valid ip 
selected. So when we click ok, "ipaddress=-1" wont be sent as a parameter to 
the api call.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to 
reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be 
closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the 
boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ![Screenshot 2019-12-30 at 09 52 
23](https://user-images.githubusercontent.com/10645273/71574697-2fbf4700-2aea-11ea-8d5a-d28f6b76ec8c.png)
   ![Screenshot 2019-12-30 at 09 52 
33](https://user-images.githubusercontent.com/10645273/71574702-32ba3780-2aea-11ea-8f50-22f577bceda6.png)
   
   ## How Has This Been Tested?
   1 . Navigate to "Networks" section in the main UI
   2 . Select any network from the list.
   3 . Click on "View IP address" button.
   4 . Now click on "Acquire New IP" button on the top right. This will open up 
a new pop up window with drop down list of all IP address belonging to that 
network
   5 . Select any of the IP address.
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to