DaanHoogland commented on a change in pull request #3680: [WIP: DO NOT MERGE]
CloudStack Kubernetes Service
URL: https://github.com/apache/cloudstack/pull/3680#discussion_r364173114
##########
File path:
server/src/main/java/com/cloud/api/query/dao/NetworkOfferingJoinDao.java
##########
@@ -27,9 +27,9 @@
public interface NetworkOfferingJoinDao extends
GenericDao<NetworkOfferingJoinVO, Long> {
- List<NetworkOfferingJoinVO> findByDomainId(long domainId);
+ List<NetworkOfferingJoinVO> findByDomainId(long domainId, Boolean
includeAllDomainOffering);
Review comment:
can you please add javadoc to explain the parameters here. I found them not
to be intuitive with the implementation in the dao impl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
