shwstppr commented on issue #3680: [WIP: DO NOT MERGE] CloudStack Kubernetes Service URL: https://github.com/apache/cloudstack/pull/3680#issuecomment-573052818 @DaanHoogland can please have a look at changes now, refactored code with worker classes. Since I workers on demand, had to call ComponentContext.inject() on their instantiation, https://github.com/apache/cloudstack/blob/3e3840b43f7e6bed079c4a2475465c9afe0e316f/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java#L935-L937 Was getting issue with injecting daos from com.cloud.kubernetes package so had to pass KubernetesClusterManagerImpl instance in worker constructors and set them, https://github.com/apache/cloudstack/blob/3e3840b43f7e6bed079c4a2475465c9afe0e316f/plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java#L132-L135 Let me know if they can be done in a better way. @poussa that noderootdisksize NPE should be fixed now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
