ravening opened a new pull request #3807: Enhancement: Allow creating network with duplicate name URL: https://github.com/apache/cloudstack/pull/3807 Add a global setting to disable creating networks with same name in an account Add a global setting to disable creating network without mentioning the start and end IPv4 or IPv6 address ## Description <!--- Describe your changes in detail --> By default we can create networks with the same name in the account. Sometimes we should not create the networks with same name. This change adds a global setting which prevents creating the network with same name. The default value is true and set it to false to prevent creating network with same names. Also its possible to create a shared network without mentioning the start and the end IPv4 or IPv6 address. This change adds a global setting which prevents creating a shared network without specifying the start and the end IPv4 or IPv6 address <!-- For new features, provide link to FS, dev ML discussion etc. --> <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. --> <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged --> <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" --> <!-- Fixes: # --> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [X] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ## Screenshots (if appropriate): ## How Has This Been Tested? <!-- Please describe in detail how you tested your changes. --> <!-- Include details of your testing environment, and the tests you ran to --> <!-- see how your change affects other areas of the code, etc. --> Creating a network with same names 1 . Set the global setting ```allow.duplicate.networkname``` to true 2. Create a new network with the name "test". 3. Try to create another network with the same name. This should create the second network with the same name 4. Now set the above global setting value to false 5. Try to create another network with same name. 6. No exception will be thrown while creating the network with same name Creating a network without specifying the start and end IPv4 or IPv6 address 1. Set the global setting ```allow.empty.start.end.ipaddress``` to true 2. Create a shared network without mentioning the start and the end IPv4 or IPv6 address 3. You will be able to create network successfully 4. Now set the above global setting value to false 5. Try to create another shared network without mentioning the start or the end IPv4 or IPv6 address 6. An exception will be thrown while creating the shared network <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
