rhtyd commented on a change in pull request #3840: Fix listing management
server by parameters
URL: https://github.com/apache/cloudstack/pull/3840#discussion_r372743279
##########
File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java
##########
@@ -3832,20 +3832,43 @@ protected ResourceDetailResponse
createResourceDetailsResponse(ResourceDetail re
@Override
public ListResponse<ManagementServerResponse>
listManagementServers(ListMgmtsCmd cmd) {
ListResponse<ManagementServerResponse> response = new ListResponse<>();
- List<ManagementServerResponse> result = new ArrayList<>();
- for (ManagementServerHostVO mgmt : managementServerHostDao.listAll()) {
- ManagementServerResponse mgmtResponse = new
ManagementServerResponse();
- mgmtResponse.setId(mgmt.getUuid());
- mgmtResponse.setName(mgmt.getName());
- mgmtResponse.setState(mgmt.getState());
- mgmtResponse.setVersion(mgmt.getVersion());
- mgmtResponse.setObjectName("managementserver");
- result.add(mgmtResponse);
- }
- response.setResponses(result);
+ Pair<List<ManagementServerHostVO>, Integer> result =
listManagementServersInternal(cmd);
+ List<ManagementServerResponse> hostResponses = new ArrayList<>();
+
+ for(ManagementServerHostVO host : result.first()) {
Review comment:
Add space after for and ifs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
