weizhouapache commented on issue #3491: KVM: Propagating changes on host parameters to the agents URL: https://github.com/apache/cloudstack/pull/3491#issuecomment-580436366 > Hi @weizhouapache, some of this functionality is already existing for the software load balancing PR, in which changing the value of 'host', 'indirect.agent.lb.algorithm' or 'indirect.agent.lb.algorithm' triggers a command being sent to each connected agent. Can you please check this existing functionality to reuse some parts of it perhaps? @nvazquez yes, there are some similar codes in server/src/main/java/org/apache/cloudstack/agent/lb/IndirectAgentLBServiceImpl.java IMHO, It make more sense to add these code in AgentManagerImpl.java instead of IndirectAgentLBServiceImpl.java. What do you think ? I can remove some duplicated code in IndirectAgentLBServiceImpl.java.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
