nvazquez commented on a change in pull request #3491: KVM: Propagating changes
on host parameters to the agents
URL: https://github.com/apache/cloudstack/pull/3491#discussion_r381270274
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -461,6 +471,24 @@ private void overProvisioningFactorsForValidation() {
overprovisioningFactorsForValidation.add(CapacityManager.StorageOverprovisioningFactor.key());
}
+ private void initMessageBusListener() {
+ messageBus.subscribe(EventTypes.EVENT_CONFIGURATION_VALUE_EDIT, new
MessageSubscriber() {
+ @Override
+ public void onPublishMessage(String serderAddress, String subject,
Object args) {
+ String globalSettingUpdated = (String) args;
+ if (Strings.isNullOrEmpty(globalSettingUpdated)) {
+ return;
+ }
+ if
(globalSettingUpdated.equals(ApiServiceConfiguration.ManagementServerAddresses.key())
||
+
globalSettingUpdated.equals(IndirectAgentLBServiceImpl.IndirectAgentLBAlgorithm.key()))
{
+ _indirectAgentLB.propagateMSListToAgents();
Review comment:
I think we can unify both calls as they do basically the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
