slavkap commented on issue #3949: Fix CloudRuntimeException of migrated volume for Volume stats URL: https://github.com/apache/cloudstack/pull/3949#issuecomment-598190351 @Spaceman1984 thanks that you spend time to test it! My bad that I didn't pull the latest changes and the fix is from #3884 where mgmt sends the path rather than the UUID of the volume. Unfortunately I couldn't reproduce the NPE that you hit. I have tested it with the latest changes and in this case you wouldn't get the runtime exception. I think that the exception is not hidden because we send it back to the management for example like this: DEBUG [c.c.a.m.AgentManagerImpl] (StatsCollector-2:ctx-bc39a30f) (logid:cd207a3e) Details from executing class com.cloud.agent.api.GetVolumeStatsCommand: Can't get vm disk stats: Unable to attach volume a43deb8f-b8b5-4e73-9043-76298cacd27b. Error: Error: volume 'a43deb8f-b8b5-4e73-9043-76298cacd27b' does not exist. In such cases when CloudRuntimeException is thrown we won't fill up the agent's log with the stack trace
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
