This is an automated email from the ASF dual-hosted git repository.

gabriel pushed a commit to branch snapshot-deletion-issues
in repository https://gitbox.apache.org/repos/asf/cloudstack.git

commit e109949e3a9e386b810c28132de6de420f5d6a03
Author: GabrielBrascher <gabr...@apache.org>
AuthorDate: Wed Nov 27 12:24:29 2019 -0200

    Remove "dummy" boolean return statement
---
 .../apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java    | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git 
a/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
 
b/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
index a819384..b2ff46c 100644
--- 
a/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
+++ 
b/engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/snapshot/DefaultSnapshotStrategy.java
@@ -340,8 +340,7 @@ public class DefaultSnapshotStrategy extends 
SnapshotStrategyBase {
         if (snapshotOnPrimary != null) {
             long volumeId = snapshotOnPrimary.getVolumeId();
             VolumeVO volumeVO = volumeDao.findById(volumeId);
-            boolean isVolumeOnPrimary = volumeVO != null && 
volumeVO.getRemoved() == null;
-            return isVolumeOnPrimary;
+            return volumeVO != null && volumeVO.getRemoved() == null;
         }
         return false;
     }

Reply via email to