andrijapanicsb edited a comment on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-602768635 Not good (still testing a few more scenarios and will update this comment once done): ## XENSERVER (7.1): ### snapshot.backup.to.secondary = TRUE (default) MANUAL SNAPS: LGTM - deletion works fine - removed from both primary/secondary store, DB records in snapshost_store_reg marked as DESTROYED, all good. SCHEDULED SNAPS: MAYBE OK - someone should advise - for disk snaps we are making snap chains (parent_snapshot_id pointing to the ID of the previous scheduled snapshot) and while DB says that older snaps are deleted, it's not really true on storage side, but as those are snap diff snaps (chain) - it makes sense that it doesn't delete the older/parent snap while there are child/linked snaps), but an older snap can be selectively deleted manually - which is a bit strange, as it would break the snap chain) ### snapshot.backup.to.secondary = FALSE MANUAL SNAPS: LGTM deletion works fine - removed from both primary store, DB records in snapshost_store_ref marked as DESTROYED, all good. SCHEDULED SNAPS: TO BE TESTED - will edit here once it completes+ ## KVM (CENT7.1) ### snapshot.backup.to.secondary TRUE (default) MANUAL SNAPS: LGTM - deletion works fine - removed from both primary/secondary store, DB records in snapshost_store_reg marked as DESTROYED, all good. - I also see we are NOT keeping the snap on the QCOW2 file (good, as we made a copy to sec storage) - and even though the "PRIMARY" record (store_role) is still created and kept as "Ready" in snapshost_store_ref - it does get properly marked as DESTROYED when snap is deleted with no exception SCHEDULED SNAPS: - works fine, created and deleted as expected in both DB and on the primary/secondary stor. ### snapshot.backup.to.secondary = FALSE MANUAL SNAPS: BROKEN - can't even create manual KVM volume snap SCHEDULED SNAPS: NA - not tested as manual ones fail ### VMware not tested, but will re-test that it's NOT affected once we have everything else fixed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
