GabrielBrascher commented on a change in pull request #3982: Updated 3 error
messages to replace the word 'matches' with 'match'
URL: https://github.com/apache/cloudstack/pull/3982#discussion_r397756642
##########
File path:
server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java
##########
@@ -428,13 +428,13 @@ private ServiceOfferingVO
getUnmanagedInstanceServiceOffering(final UnmanagedIns
serviceOffering =
serviceOfferingDao.getComputeOffering(serviceOffering, parameters);
} else {
if (!cpu.equals(serviceOffering.getCpu()) &&
!instance.getPowerState().equals(UnmanagedInstanceTO.PowerState.PowerOff)) {
- throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
String.format("Service offering (%s) %d CPU cores does not matches VM CPU cores
%d and VM is not in powered off state (Power state: %s)",
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu,
instance.getPowerState()));
+ throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR,
String.format("Service offering (%s) %d CPU cores does not match VM CPU cores
%d and VM is not in powered off state (Power state: %s)",
serviceOffering.getUuid(), serviceOffering.getCpu(), cpu,
instance.getPowerState()));
Review comment:
Additionally, considering the fact that **CPU cores** is plural (of a _CPU
core_) it should be "CPU core**s do** not **match**"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
