DaanHoogland commented on a change in pull request #3976: Enable sending
hypervior host name via metadata - VR and Config Drive
URL: https://github.com/apache/cloudstack/pull/3976#discussion_r399314758
##########
File path:
server/src/main/java/com/cloud/network/element/ConfigDriveNetworkElement.java
##########
@@ -327,6 +355,30 @@ public void rollbackMigration(NicProfile nic, Network
network, VirtualMachinePro
public void commitMigration(NicProfile nic, Network network,
VirtualMachineProfile vm, ReservationContext src, ReservationContext dst) {
}
+ private void recreateConfigDriveIso(NicProfile nic, Network network,
VirtualMachineProfile vm, DeployDestination dest) throws
ResourceUnavailableException {
+ if (nic.isDefaultNic() &&
_networkModel.getUserDataUpdateProvider(network).getProvider().equals(Provider.ConfigDrive))
{
+ DiskTO diskToUse = null;
+ for (DiskTO disk : vm.getDisks()) {
+ if (disk.getType() == Volume.Type.ISO && disk.getPath() !=
null && disk.getPath().contains("configdrive")) {
+ diskToUse = disk;
+ break;
+ }
+ }
+ final UserVmVO userVm = _userVmDao.findById(vm.getId());
+ final Account caller = CallContext.current().getCallingAccount();
+
+ if (userVm != null) {
+ final boolean isWindows =
_guestOSCategoryDao.findById(_guestOSDao.findById(userVm.getGuestOSId()).getCategoryId()).getName().equalsIgnoreCase("Windows");
Review comment:
seems like this statement could do with its own method for readability (will
be optimised out by the compiler anyway).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
