andrijapanicsb edited a comment on issue #3969: Snapshot deletion issues URL: https://github.com/apache/cloudstack/pull/3969#issuecomment-610018095 Tested the latest commit - to confirm proper logging: ## snapshot.backup.to.secondary=TRUE ### Normal case - 2 rows present, for both IMAGE/PRIMARY > 2020-04-06 20:14:44,739 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-2:ctx-4eecdad6 job-420 ctx-67c357b4) (logid:a8e3d3a0) Successfully deleted snapshot (id: 48) on primary storage. > 2020-04-06 20:14:44,739 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-2:ctx-4eecdad6 job-420 ctx-67c357b4) (logid:a8e3d3a0) Successfully deleted snapshot (id: 48) on secondary storage. ### case 1 - PRIMARY row manually removed from snapshot_store_ref table - only the IMAGE rows present (not normal, or otherwise possible to happen on it's own) > 2020-04-06 20:16:27,982 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) Snapshot (id: 49) **has been deleted on secondary storage.** > 2020-04-06 20:16:27,985 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) The snapshot (id: 49) **could not be found/deleted on primary storage.** > 2020-04-06 20:16:27,985 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-4:ctx-9fadd1ca job-423 ctx-5e982b61) (logid:b6224956) Successfully deleted snapshot (id: 49) on secondary storage. (and GC removed the IMAGE row - so all good, didn't break or something) ### case 2 - I removed manually the IMAGE row from snap_store_ref, only PRIMARY left > 2020-04-06 20:18:27,146 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-6:ctx-fd12e158 job-426 ctx-30f38c9c) (logid:13bbc143) Can't find snapshot [snapshot id: 50] on backup storage > ... > 2020-04-06 20:18:27,475 DEBUG [o.a.c.s.s.DefaultSnapshotStrategy] (API-Job-Executor-6:ctx-fd12e158 job-426 ctx-30f38c9c) (logid:13bbc143) Successfully deleted snapshot (id: 50) on primary storage. So all good. @GabrielBrascher after your testing, if you are happy, I plan to merge this one and shift any outstanding (DB garbage for PRIMARY in snap_store_ref) to a new use #4018
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
