shwstppr commented on a change in pull request #4017: [UI] Update ISO 
permissions
URL: https://github.com/apache/cloudstack/pull/4017#discussion_r405274365
 
 

 ##########
 File path: ui/scripts/templates.js
 ##########
 @@ -3357,6 +3357,319 @@
                                 notification: {
                                     poll: pollAsyncJobResult
                                 }
+                            },
+
+                            shareIso: {
 
 Review comment:
   ```suggestion
                               shareISO: {
   ```
   since download action was written as downloadISO it would be nice to follow 
the same scheme or change it for download as well. This might create confusion 
in future as in line 4190 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to