sureshanaparti commented on a change in pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#discussion_r433412531
##########
File path: server/src/main/java/org/apache/cloudstack/acl/RoleManagerImpl.java
##########
@@ -146,10 +150,89 @@ public RoleVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
+ @ActionEvent(eventType = EventTypes.EVENT_ROLE_CREATE, eventDescription =
"creating Role")
+ public Role createRole(String name, Role role, String description) {
+ checkCallerAccess();
+ return Transaction.execute(new TransactionCallback<RoleVO>() {
+ @Override
+ public RoleVO doInTransaction(TransactionStatus status) {
+ RoleVO newRoleVO = roleDao.persist(new RoleVO(name,
role.getRoleType(), description));
+ if (newRoleVO == null) {
+ throw new CloudRuntimeException("Unable to add role into
DB, is DB full?");
Review comment:
> nit - Can you improve the exception message?
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
