rhtyd commented on a change in pull request #4084:
URL: https://github.com/apache/cloudstack/pull/4084#discussion_r434950866
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
##########
@@ -831,8 +832,12 @@ protected String mount(String path, String parent, Integer
nfsVersion) {
String result = null;
Script command = new Script(true, "mount", _timeout, s_logger);
command.add("-t", "nfs");
- if (nfsVersion != null){
- command.add("-o", "vers=" + nfsVersion);
+ if (nfsMajorVersion != null){
+ String nfsVersion = "vers=" + nfsMajorVersion;
+ if (nfsMinorVersion != null && nfsMajorVersion >= 4) {
Review comment:
Is minor version only supported for version 4 and above? If so, why not
simply parse and pass the major version when it is less than `3`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
