rhtyd commented on a change in pull request #4068:
URL: https://github.com/apache/cloudstack/pull/4068#discussion_r438669648
##########
File path: python/lib/cloudutils/test.py
##########
@@ -0,0 +1,11 @@
+#!/usr/bin/env python3
+
+from .utilities import bash
+import logging
+
+cmd = bash("route -n|awk \'/^0.0.0.0/ {print $2,$8}\'")
+if not cmd.isSuccess():
+ logging.debug("Failed to get default route")
+ raise CloudRuntimeException("Failed to get default route")
+
+result = cmd.getStdout().split(" ")
Review comment:
@davidjumani @shwstppr This looks like a new file, if this was for
testing while developing the feature and is unecessary (not tied or run with
travis/trillia) - remove it please.
##########
File path: python/lib/cloudutils/syscfg.py
##########
@@ -193,6 +200,17 @@ def __init__(self, glbEnv):
nfsConfig(self),
cloudAgentConfig(self)]
+#it covers RHEL8
Review comment:
Remove comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
