RodrigoDLopez commented on pull request #4140:
URL: https://github.com/apache/cloudstack/pull/4140#issuecomment-643358376


   @davidjumani 
   I tested this enhancement with Cloudmonkey and used JQ to parse the output.
   My Environment have 2 Zones and some fake templates named T<int> copied into 
both zones
   
   * Test 01
   ```
   cloudmonkey -p acs listtemplates \
   templatefilter=self \
   showunique=true \
   | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
   ```
   
   **Expected result:** List all my templates without duplicate entries.
   **Result:** the output brought all templates duplicates too
   ```
   name:        T1      id: 422b3235-ad7f-49fa-93ec-2c2df9140569        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T2      id: 6d224f3a-057e-4be3-bf27-ea911a77b87d        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T3      id: f302a9f9-50e6-4990-a746-3185be9fa6fb        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T4      id: a10d6bb8-dea5-45a9-8e45-4fec5456c885        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T5      id: 584317d2-009e-46eb-a5b0-ef005231bd14        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T6      id: 07994afd-ec0d-4098-ba86-c5ae1a4198df        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T7      id: 09face5a-f496-47cf-a367-1e872bb1c659        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T8      id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T9      id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T10     id: c3c8e05c-f8b9-44f7-91c8-b9679de95b30        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T11     id: bd552d64-7354-4e51-9c57-b7991f5d3a95        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T12     id: b21ffae9-cf69-4c3e-b204-3ea9202a662a        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T3      id: f302a9f9-50e6-4990-a746-3185be9fa6fb        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T4      id: a10d6bb8-dea5-45a9-8e45-4fec5456c885        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T5      id: 584317d2-009e-46eb-a5b0-ef005231bd14        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T6      id: 07994afd-ec0d-4098-ba86-c5ae1a4198df        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T7      id: 09face5a-f496-47cf-a367-1e872bb1c659        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T8      id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T9      id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T10     id: c3c8e05c-f8b9-44f7-91c8-b9679de95b30        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T11     id: bd552d64-7354-4e51-9c57-b7991f5d3a95        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T12     id: b21ffae9-cf69-4c3e-b204-3ea9202a662a        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   ```
   
   * Test 02
   ```
   cloudmonkey -p acs listtemplates \
   templatefilter=self \
   pagesize=5 \
   page=1 \
   showunique=true \
   | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
   ```
   
   **Expected result:** List only 5 templates
   **Result:** All good, as expected
   ```
   name:        T1      id: 422b3235-ad7f-49fa-93ec-2c2df9140569        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T2      id: 6d224f3a-057e-4be3-bf27-ea911a77b87d        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T3      id: f302a9f9-50e6-4990-a746-3185be9fa6fb        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T4      id: a10d6bb8-dea5-45a9-8e45-4fec5456c885        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T5      id: 584317d2-009e-46eb-a5b0-ef005231bd14        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   ```
   * Test 03
   ```
   cloudmonkey -p acs listtemplates \
   templatefilter=self \
   pagesize=7 \
   page=1 \
   showunique=true \
   | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
   ```
   
   **Expected result:** List only 7 templates
   **Result:** All good, as expected
   ```
   
   name:        T1      id: 422b3235-ad7f-49fa-93ec-2c2df9140569        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T2      id: 6d224f3a-057e-4be3-bf27-ea911a77b87d        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T3      id: f302a9f9-50e6-4990-a746-3185be9fa6fb        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T4      id: a10d6bb8-dea5-45a9-8e45-4fec5456c885        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T5      id: 584317d2-009e-46eb-a5b0-ef005231bd14        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T6      id: 07994afd-ec0d-4098-ba86-c5ae1a4198df        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T7      id: 09face5a-f496-47cf-a367-1e872bb1c659        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   ```
   * Test 04
   ```
   cloudmonkey -p acs listtemplates \
   templatefilter=self \
   pagesize=9 \
   page=1 \
   showunique=true \
   | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
   ```
   
   **Expected result:** List only 9 templates
   **Result:** the output brought 16 templates and some duplicate entries
   ```
   name:        T1      id: 422b3235-ad7f-49fa-93ec-2c2df9140569        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T2      id: 6d224f3a-057e-4be3-bf27-ea911a77b87d        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T3      id: f302a9f9-50e6-4990-a746-3185be9fa6fb        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T4      id: a10d6bb8-dea5-45a9-8e45-4fec5456c885        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T5      id: 584317d2-009e-46eb-a5b0-ef005231bd14        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T6      id: 07994afd-ec0d-4098-ba86-c5ae1a4198df        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T7      id: 09face5a-f496-47cf-a367-1e872bb1c659        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T8      id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T9      id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09        zoneid: 
bfa05e73-7948-419f-a47d-29b498bf3ef9
   name:        T3      id: f302a9f9-50e6-4990-a746-3185be9fa6fb        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T4      id: a10d6bb8-dea5-45a9-8e45-4fec5456c885        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T5      id: 584317d2-009e-46eb-a5b0-ef005231bd14        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T6      id: 07994afd-ec0d-4098-ba86-c5ae1a4198df        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T7      id: 09face5a-f496-47cf-a367-1e872bb1c659        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T8      id: f6e92bc2-5dbd-4c9a-bba6-1ec4f1402667        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T9      id: c79b03a0-c9c8-431a-a4a4-a11164ea2f09        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   ```
   
   Whithout `showunique` parameter, I receive duplicate entries as well, but 
the `pagesize` was respected
   
   * Test 05
   ```
   cloudmonkey -p acs listtemplates \
   templatefilter=self \
   pagesize=10 \
   page=1 \
   showunique=true \
   | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
   ```
   
   **Expected result:** List only 10 templates
   **Result:** As the test 04, I received duplicate entries, and the `pagesize` 
was not respected.  
   But the second page seems to be okay.
   ```
   cloudmonkey -p acs listtemplates \
   templatefilter=self \
   pagesize=10 \
   page=2 \
   showunique=true \
   | jq -r '.template[] | "name:\t\(.name)\tid: \(.id)\tzoneid: \(.zoneid)"'
   ```
   
   **Expected result:** List the remaining templates, without duplicates.
   **Result:** all good, bring the remaining templates, without duplicate 
entries
   ```
   name:        T11     id: bd552d64-7354-4e51-9c57-b7991f5d3a95        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   name:        T12     id: b21ffae9-cf69-4c3e-b204-3ea9202a662a        zoneid: 
8e4d0af1-fd82-4a25-bf90-e0adfb0a4e8a
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to