[GitHub] [cloudstack] rhtyd commented on a change in pull request #4164: Adding listall to listLdapConfigurations

[GitBox]

rhtyd commented on a change in pull request #4164:
URL: https://github.com/apache/cloudstack/pull/4164#discussion_r444288743



##########
File path: 
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListConfigurationCmd.java
##########
@@ -117,4 +121,8 @@ public void setPort(final int port) {
     public void setDomainId(final Long domainId) {
         this.domainId = domainId;
     }
+
+    public boolean listAll() {
+        return listAll == null ? false : listAll;

Review comment:
       nit - can be simplified as listAll != null && listAll




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org