Spaceman1984 commented on a change in pull request #4138:
URL: https://github.com/apache/cloudstack/pull/4138#discussion_r447742017



##########
File path: 
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
##########
@@ -218,7 +219,10 @@ public long download(boolean resume, 
DownloadCompleteCallback callback) {
             errorString = hte.getMessage();

Review comment:
       > Why not set it if errorString is null as below?
   
   It may be an easy code change, but then the scope of this issue will be 
greater, which will require more testing as well.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to