[GitHub] [cloudstack] ravening commented on pull request #4200: Allow domain admins to create offering without mentioning domainid

[GitBox]

ravening commented on pull request #4200:
URL: https://github.com/apache/cloudstack/pull/4200#issuecomment-663377814


   > nice enhance @ravening
   > I ran some manual tests using 2 accounts
   > 
   > * admin-domain that belongs to /domain1
   > * admin-subdomain that belongs to /domain1/subdomain1
   > 
   > With the 'admin-domain' account I was able to create offers on 'domain1' 
without making it explicit, which is the PR proposal
   > 
   > ```
   > () 🐱 > create diskoffering name=admindomain displaytext=admindomain 
customized=true
   > {
   >   "diskoffering": {
   >     "created": "2020-07-23T20:21:28+0000",
   >     "disksize": 0,
   >     "displayoffering": true,
   >     "displaytext": "admindomain",
   >     "domain": "/domain1/",
   >     "domainid": "86efc439-bd1e-4a9e-ac06-aead0c8b7af3",
   >     "id": "8b7d1b26-9c44-45b7-817d-f52b78a7b7ee",
   >     "iscustomized": true,
   >     "name": "admindomain",
   >     "provisioningtype": "thin",
   >     "storagetype": "shared"
   >   }
   > }
   > ```
   > 
   > works like a charm.
   > I tested many list commands, and everything is working as expected.
   > 
   > With the 'admin-subdomain1' account I got the same behavior, I was able to 
create offers on '/domain1/subdomain1' without making it explicit
   > 
   > ```
   > () 🐱 > create diskoffering name=subdomain displaytext=subdomain 
customized=true
   > {
   >   "diskoffering": {
   >     "created": "2020-07-23T20:31:58+0000",
   >     "disksize": 0,
   >     "displayoffering": true,
   >     "displaytext": "subdomain",
   >     "domain": "/domain1/subdomain1/",
   >     "domainid": "a412bf4c-ab00-448b-9ab9-07b05564402b",
   >     "id": "0386c751-4e6f-4322-a946-37987b597025",
   >     "iscustomized": true,
   >     "name": "subdomain",
   >     "provisioningtype": "thin",
   >     "storagetype": "shared"
   >   }
   > }
   > ```
   > 
   > code looks good to me, makes it easy to create offers for accounts that 
are domain admin.
   > I am +1 with this PR proposal.
   
   Thanks for testing


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org