RodrigoDLopez commented on pull request #4283: URL: https://github.com/apache/cloudstack/pull/4283#issuecomment-762960273
> for vms, we use "cmk find hostsformigration" to list all hosts, it also mentions if the hosts are suitable or not for migration. > if users try to migrate vm to a unsuitable host, cloudstack still allows it. > > for volumes, it looks like "find storagepoolsformigration" also mark storage pools with unmatched tag as "unsuitable". > https://github.com/apache/cloudstack/blob/master/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java#L72 > https://github.com/apache/cloudstack/blob/master/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java#L81 > https://github.com/apache/cloudstack/blob/master/engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java#L105 > > @rafaelweingartner @RodrigoDLopez could you please confirm it ? > if so, I think we could remove the check. @weizhouapache Exactly! Moreover, even though the override is a possibility, if the operator defines the "newDiskOffering" option, the tags are checked (tags of the new target storage pool with the new disk offering being set). The only situation that the tags are not checked is during a disk placement override that operators might execute in case of emergency or maybe for testing purposes. The goal here is to enable/empower/provide flexibility for root Admins. They are the root admins of the cloud infrastructure, and they probably know best (better than me at least) how to use/manage their cloud infrastructure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
