sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r561675920
##########
File path: server/src/main/java/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -500,6 +526,20 @@ private String composeConsoleAccessUrl(String rootUrl,
VirtualMachine vm, HostVO
return sb.toString();
}
+ /**
+ * Generates an extra parameter to be passed to noVNC server to connect to
WebSocket exposed on Vmware hosts.
+ * This method has been introduced as Vmware 7 has deprecated the previous
VNC approach to connect to VMs console.
+ * Please check:
https://docs.vmware.com/en/VMware-vSphere/7.0/rn/vsphere-esxi-vcenter-server-70-release-notes.html
+ */
+ private String generateExtraNoVNCParameter(ConsoleProxyClientParam param) {
+ String extraParam = null;
+ if (StringUtils.isNotBlank(param.getTicketAcquired())) {
+ extraParam = "wss://" + param.getClientHostAddress() +
":443/ticket/" + param.getTicketAcquired();
Review comment:
@nvazquez declare a constant for port 443 in some common class (may be
ConsoleProxyManager), and use it across.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
