This is an automated email from the ASF dual-hosted git repository. ggregory pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/commons-net.git
commit bfb2c31d72889f24d93a602b2127de2ceee80efe Author: Gary Gregory <garydgreg...@gmail.com> AuthorDate: Sat Jul 20 13:54:44 2024 -0400 Increase message limit in IMAPReply.TAGGED_RESPONSE from 80 to 500 characters --- src/changes/changes.xml | 1 + src/main/java/org/apache/commons/net/imap/IMAPReply.java | 4 ++-- src/test/java/org/apache/commons/net/imap/IMAPReplyTest.java | 7 +++++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 827d4477..c9c4f304 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -79,6 +79,7 @@ The <action> type attribute can be add,update,fix,remove. <action type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate MLSxEntryParser default constructor in favor of MLSxEntryParser.getInstance().</action> <action type="fix" dev="ggregory" due-to="Gary Gregory">Deprecate direct access to org.apache.commons.net.nntp.Article.kid and next fields.</action> <action type="fix" dev="ggregory" due-to="Gary Gregory">Fix SpotBugs CT_CONSTRUCTOR_THROW in Base64 by implementing finalize() as a noop to avoid finalizer attacks.</action> + <action type="fix" dev="ggregory" due-to="Andreas Lemke, Gary Gregory">Increase message limit in IMAPReply.TAGGED_RESPONSE from 80 to 500 characters.</action> <!-- ADD --> <action type="add" dev="ggregory" due-to="Gary Gregory">org.apache.commons.net.nntp.Article#getChild().</action> <action type="add" dev="ggregory" due-to="Gary Gregory">org.apache.commons.net.nntp.Article#getNext().</action> diff --git a/src/main/java/org/apache/commons/net/imap/IMAPReply.java b/src/main/java/org/apache/commons/net/imap/IMAPReply.java index 26070b17..10dea0c4 100644 --- a/src/main/java/org/apache/commons/net/imap/IMAPReply.java +++ b/src/main/java/org/apache/commons/net/imap/IMAPReply.java @@ -67,9 +67,9 @@ public final class IMAPReply { * * Don't look for more than 80 letters. * Don't look for more than 80 non-whitespace. - * Don't look for more than 80 character. + * Don't look for more than 500 character. */ - private static final String TAGGED_RESPONSE = "^\\w{1,80} (\\S{1,80}).{0,80}"; + private static final String TAGGED_RESPONSE = "^\\w{1,80} (\\S{1,80}).{0,500}"; /** * Tag cannot contain: + ( ) { SP CTL % * " \ ] diff --git a/src/test/java/org/apache/commons/net/imap/IMAPReplyTest.java b/src/test/java/org/apache/commons/net/imap/IMAPReplyTest.java index 561ee925..d80fbd3a 100644 --- a/src/test/java/org/apache/commons/net/imap/IMAPReplyTest.java +++ b/src/test/java/org/apache/commons/net/imap/IMAPReplyTest.java @@ -100,6 +100,13 @@ public class IMAPReplyTest { @Test public void testGetReplyCodeOkLine() throws IOException { assertEquals(IMAPReply.OK, IMAPReply.getReplyCode("A001 OK LOGIN completed")); + assertEquals(IMAPReply.OK, + IMAPReply.getReplyCode("AAAA OK [CAPABILITY IMAP4rev1 SASL-IR LOGIN-REFERRALS ID ENABLE IDLE SORT" + + " SORT=DISPLAY THREAD=REFERENCES THREAD=REFS THREAD=ORDEREDSUBJECT" + + " MULTIAPPEND URL-PARTIAL CATENATE UNSELECT CHILDREN NAMESPACE UIDPLUS" + + " LIST-EXTENDED I18NLEVEL=1 CONDSTORE QRESYNC ESEARCH ESORT SEARCHRES WITHIN" + + " CONTEXT=SEARCH LIST-STATUS BINARY MOVE SNIPPET=FUZZY PREVIEW=FUZZY PREVIEW" + + " STATUS=SIZE SAVEDATE XLIST LITERAL+ NOTIFY SPECIAL-USE] Logged in")); } @Test