This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-collections.git
The following commit(s) were added to refs/heads/master by this push:
new 1ade1ce Use final.
1ade1ce is described below
commit 1ade1ce39493589b2f052ae73cb9e26addfa3e2d
Author: Gary Gregory <[email protected]>
AuthorDate: Sat Nov 21 12:54:13 2020 -0500
Use final.
---
src/test/java/org/apache/commons/collections4/MapUtilsTest.java | 6 +++---
.../apache/commons/collections4/bloomfilter/IndexFilterTest.java | 6 +++---
.../commons/collections4/collection/AbstractCollectionTest.java | 2 +-
.../commons/collections4/iterators/CollatingIteratorTest.java | 4 ++--
.../apache/commons/collections4/iterators/ZippingIteratorTest.java | 4 ++--
.../commons/collections4/sequence/SequencesComparatorTest.java | 2 +-
6 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/src/test/java/org/apache/commons/collections4/MapUtilsTest.java
b/src/test/java/org/apache/commons/collections4/MapUtilsTest.java
index 396af2c..80bdb5d 100644
--- a/src/test/java/org/apache/commons/collections4/MapUtilsTest.java
+++ b/src/test/java/org/apache/commons/collections4/MapUtilsTest.java
@@ -813,7 +813,7 @@ public class MapUtilsTest {
MapUtils.populateMap(map, list,
TransformedCollectionTest.STRING_TO_INTEGER_TRANSFORMER);
assertEquals(list.size(), map.size());
- for (String element : list) {
+ for (final String element : list) {
assertTrue(map.containsKey(Integer.valueOf(element)));
assertFalse(map.containsKey(element));
assertTrue(map.containsValue(element));
@@ -825,7 +825,7 @@ public class MapUtilsTest {
MapUtils.populateMap(map, list,
TransformedCollectionTest.STRING_TO_INTEGER_TRANSFORMER,
TransformedCollectionTest.STRING_TO_INTEGER_TRANSFORMER);
assertEquals(list.size(), map.size());
- for (String element : list) {
+ for (final String element : list) {
assertTrue(map.containsKey(Integer.valueOf(element)));
assertFalse(map.containsKey(element));
assertTrue(map.containsValue(Integer.valueOf(element)));
@@ -866,7 +866,7 @@ public class MapUtilsTest {
MapUtils.populateMap(map, list, (Transformer<X, Integer>) input ->
input.key, TransformerUtils.<X>nopTransformer());
assertEquals(list.size(), map.totalSize());
- for (X element : list) {
+ for (final X element : list) {
assertTrue(map.containsKey(element.key));
assertTrue(map.containsValue(element));
}
diff --git
a/src/test/java/org/apache/commons/collections4/bloomfilter/IndexFilterTest.java
b/src/test/java/org/apache/commons/collections4/bloomfilter/IndexFilterTest.java
index dfa576f..30fc11e 100644
---
a/src/test/java/org/apache/commons/collections4/bloomfilter/IndexFilterTest.java
+++
b/src/test/java/org/apache/commons/collections4/bloomfilter/IndexFilterTest.java
@@ -53,21 +53,21 @@ public class IndexFilterTest {
try {
IndexFilters.distinctIndexes(null, shape, consumer);
Assert.fail("null hasher");
- } catch (NullPointerException expected) {
+ } catch (final NullPointerException expected) {
// Ignore
}
try {
IndexFilters.distinctIndexes(hasher, null, consumer);
Assert.fail("null shape");
- } catch (NullPointerException expected) {
+ } catch (final NullPointerException expected) {
// Ignore
}
try {
IndexFilters.distinctIndexes(hasher, shape, null);
Assert.fail("null consumer");
- } catch (NullPointerException expected) {
+ } catch (final NullPointerException expected) {
// Ignore
}
diff --git
a/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
b/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
index 8958600..3341618 100644
---
a/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
+++
b/src/test/java/org/apache/commons/collections4/collection/AbstractCollectionTest.java
@@ -752,7 +752,7 @@ public abstract class AbstractCollectionTest<E> extends
AbstractObjectTest {
resetFull();
it1 = getCollection().iterator();
- for (E element : getCollection()) {
+ for (final E element : getCollection()) {
assertTrue("Iterator for full collection should haveNext",
it1.hasNext());
it1.next();
}
diff --git
a/src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
b/src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
index aa9b167..52689f5 100644
---
a/src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
+++
b/src/test/java/org/apache/commons/collections4/iterators/CollatingIteratorTest.java
@@ -97,7 +97,7 @@ public class CollatingIteratorTest extends
AbstractIteratorTest<Integer> {
public void testIterateEven() {
final CollatingIterator<Integer> iter = new
CollatingIterator<>(comparator);
iter.addIterator(evens.iterator());
- for (Integer even : evens) {
+ for (final Integer even : evens) {
assertTrue(iter.hasNext());
assertEquals(even, iter.next());
assertEquals(0, iter.getIteratorIndex());
@@ -129,7 +129,7 @@ public class CollatingIteratorTest extends
AbstractIteratorTest<Integer> {
final CollatingIterator<Integer> iter = new
CollatingIterator<>(comparator);
iter.addIterator(evens.iterator());
iter.addIterator(evens.iterator());
- for (Integer even : evens) {
+ for (final Integer even : evens) {
assertTrue(iter.hasNext());
assertEquals(even, iter.next());
assertEquals(0, iter.getIteratorIndex());
diff --git
a/src/test/java/org/apache/commons/collections4/iterators/ZippingIteratorTest.java
b/src/test/java/org/apache/commons/collections4/iterators/ZippingIteratorTest.java
index a817d73..f4caa8c 100644
---
a/src/test/java/org/apache/commons/collections4/iterators/ZippingIteratorTest.java
+++
b/src/test/java/org/apache/commons/collections4/iterators/ZippingIteratorTest.java
@@ -80,7 +80,7 @@ public class ZippingIteratorTest extends
AbstractIteratorTest<Integer> {
public void testIterateEven() {
@SuppressWarnings("unchecked")
final ZippingIterator<Integer> iter = new
ZippingIterator<>(evens.iterator());
- for (Integer even : evens) {
+ for (final Integer even : evens) {
assertTrue(iter.hasNext());
assertEquals(even, iter.next());
}
@@ -113,7 +113,7 @@ public class ZippingIteratorTest extends
AbstractIteratorTest<Integer> {
public void testIterateEvenEven() {
final ZippingIterator<Integer> iter = new
ZippingIterator<>(evens.iterator(), evens.iterator());
- for (Integer even : evens) {
+ for (final Integer even : evens) {
assertTrue(iter.hasNext());
assertEquals(even, iter.next());
assertTrue(iter.hasNext());
diff --git
a/src/test/java/org/apache/commons/collections4/sequence/SequencesComparatorTest.java
b/src/test/java/org/apache/commons/collections4/sequence/SequencesComparatorTest.java
index 3164559..6062fc6 100644
---
a/src/test/java/org/apache/commons/collections4/sequence/SequencesComparatorTest.java
+++
b/src/test/java/org/apache/commons/collections4/sequence/SequencesComparatorTest.java
@@ -129,7 +129,7 @@ public class SequencesComparatorTest {
final ExecutionVisitor<String> ev = new ExecutionVisitor<>();
- for (List<String> element : shadokSentences) {
+ for (final List<String> element : shadokSentences) {
for (final List<String> shadokSentence : shadokSentences) {
ev.setList(element);
new SequencesComparator<>(element,
