:snail: some derps on my part
Project: http://git-wip-us.apache.org/repos/asf/cordova-lib/repo Commit: http://git-wip-us.apache.org/repos/asf/cordova-lib/commit/52c38889 Tree: http://git-wip-us.apache.org/repos/asf/cordova-lib/tree/52c38889 Diff: http://git-wip-us.apache.org/repos/asf/cordova-lib/diff/52c38889 Branch: refs/heads/no-lazy-load Commit: 52c38889e8c625c6c808b21de9315f6078a9e07d Parents: ca7a068 Author: filmaj <maj....@gmail.com> Authored: Fri Jun 9 14:17:55 2017 -0500 Committer: filmaj <maj....@gmail.com> Committed: Fri Jun 9 14:17:55 2017 -0500 ---------------------------------------------------------------------- src/cordova/cordova.js | 2 +- src/cordova/util.js | 9 ++++++--- src/plugman/plugman.js | 3 ++- src/util/alias.js | 2 +- 4 files changed, 10 insertions(+), 6 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/52c38889/src/cordova/cordova.js ---------------------------------------------------------------------- diff --git a/src/cordova/cordova.js b/src/cordova/cordova.js index c180f7d..5b091e3 100644 --- a/src/cordova/cordova.js +++ b/src/cordova/cordova.js @@ -52,7 +52,7 @@ exports = module.exports = { emulate: require('./emulate'), plugin: require('./plugin'), plugins: require('./plugin'), - serve: require('./serve')); + serve: require('./serve'), platform: require('./platform'), platforms: require('./platform'), compile: require('./compile'), http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/52c38889/src/cordova/util.js ---------------------------------------------------------------------- diff --git a/src/cordova/util.js b/src/cordova/util.js index cf6845d..59c655d 100644 --- a/src/cordova/util.js +++ b/src/cordova/util.js @@ -27,6 +27,7 @@ var fs = require('fs'), nopt = require('nopt'), Q = require('q'), semver = require('semver'), + aliasMethod = require('../util/alias'), platforms = require('../platforms/platforms'); // Global configuration paths @@ -55,14 +56,16 @@ Object.defineProperty(exports,'libDirectory', { } }); -addModuleProperty(module, 'plugin_parser', './plugin_parser'); - +exports.plugin_parser = require('./plugin_parser'); +exports.raw = {}; +// Alias the plugin_parser method to the raw:{} object above. +// Emits a deprecation warning if utilized, in prep for removal of `raw`. +aliasMethod('plugin_parser', exports, 'cordova_util'); exports.isCordova = isCordova; exports.cdProjectRoot = cdProjectRoot; exports.deleteSvnFolders = deleteSvnFolders; exports.listPlatforms = listPlatforms; exports.findPlugins = findPlugins; -exports.addModuleProperty = addModuleProperty; exports.appDir = appDir; exports.projectWww = projectWww; exports.projectConfig = projectConfig; http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/52c38889/src/plugman/plugman.js ---------------------------------------------------------------------- diff --git a/src/plugman/plugman.js b/src/plugman/plugman.js index 3b65b73..f7c6bb6 100644 --- a/src/plugman/plugman.js +++ b/src/plugman/plugman.js @@ -20,6 +20,7 @@ // copyright (c) 2013 Andrew Lunny, Adobe Systems var events = require('cordova-common').events; +var aliasMethodToRawWithDeprecationNotice = require('../util/alias'); var Q = require('q'); var plugman = { @@ -50,7 +51,7 @@ var modulesToAlias = ['install', 'uninstall', 'fetch', 'browserify', 'help', 'createpackagejson']; modulesToAlias.forEach(function(mod) { - aliasMethodToRawWithDeprecationNotice(mod, module.exports, 'plugman'); + aliasMethodToRawWithDeprecationNotice(mod, plugman, 'plugman'); }); plugman.commands = { http://git-wip-us.apache.org/repos/asf/cordova-lib/blob/52c38889/src/util/alias.js ---------------------------------------------------------------------- diff --git a/src/util/alias.js b/src/util/alias.js index d44cb0b..edc32bc 100644 --- a/src/util/alias.js +++ b/src/util/alias.js @@ -24,4 +24,4 @@ module.exports = function aliasMethodToRawWithDeprecationNotice(property, target cordova_events.emit('warn', 'Use of `' + component + '.raw.*` methods is deprecated and `' + component + '.raw` will be removed in a future release. Please migrate to using the top-level `' + component + '.*` methods instead.'); targetObj[property].apply(targetObj, arguments); }; -} +}; --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org