This is an automated email from the ASF dual-hosted git repository. janpio pushed a commit to branch janpio-msbuild_cleanup in repository https://gitbox.apache.org/repos/asf/cordova-windows.git
commit d20ee296eab41051e36dc26c48a753bfbb7e46a0 Author: Jan Piotrowski <piotrow...@gmail.com> AuthorDate: Thu Feb 15 11:54:50 2018 +0100 re-enable tests (but 3) --- spec/unit/build.spec.js | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/spec/unit/build.spec.js b/spec/unit/build.spec.js index da35402..81b2ada 100644 --- a/spec/unit/build.spec.js +++ b/spec/unit/build.spec.js @@ -145,7 +145,7 @@ describe('run method', function () { }).toThrow(); }); - xit('should respect build configuration from \'buildConfig\' option', function (done) { + it('should respect build configuration from \'buildConfig\' option', function (done) { createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: jasmine.createSpy(), path: testPath }]); var buildConfigPath = path.resolve(__dirname, 'fixtures/fakeBuildConfig.json'); @@ -170,7 +170,7 @@ describe('run method', function () { }); }, 20000); - xit('spec.4 should call buildProject of MSBuildTools with buildType = "release" if called with --release argument', function (done) { + it('spec.4 should call buildProject of MSBuildTools with buildType = "release" if called with --release argument', function (done) { var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) { expect(buildType).toBe('release'); }); @@ -184,7 +184,7 @@ describe('run method', function () { }); }); - xit('spec.5 should call buildProject of MSBuildTools with buildType = "debug" if called without arguments', function (done) { + it('spec.5 should call buildProject of MSBuildTools with buildType = "debug" if called without arguments', function (done) { var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) { expect(buildType).toBe('debug'); }); @@ -198,7 +198,7 @@ describe('run method', function () { }); }); - xit('spec.6 should call buildProject of MSBuildTools with buildArch = "arm" if called with --archs="arm" argument', function (done) { + it('spec.6 should call buildProject of MSBuildTools with buildArch = "arm" if called with --archs="arm" argument', function (done) { var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) { expect(buildArch).toBe('arm'); }); @@ -212,7 +212,7 @@ describe('run method', function () { }); }); - xit('spec.7 should call buildProject of MSBuildTools once for all architectures if called with --archs="arm x86 x64 anycpu" argument', function (done) { + it('spec.7 should call buildProject of MSBuildTools once for all architectures if called with --archs="arm x86 x64 anycpu" argument', function (done) { var armBuild = jasmine.createSpy(); var x86Build = jasmine.createSpy(); var x64Build = jasmine.createSpy(); @@ -273,7 +273,7 @@ describe('run method', function () { }); }); - xit('spec.9 should call buildProject of MSBuildTools if built for windows 8.1', function (done) { + it('spec.9 should call buildProject of MSBuildTools if built for windows 8.1', function (done) { var buildSpy = jasmine.createSpy(); createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]); @@ -305,7 +305,7 @@ describe('run method', function () { }); }); - xit('spec.11 should call buildProject of MSBuildTools if built for windows phone 8.1', function (done) { + it('spec.11 should call buildProject of MSBuildTools if built for windows phone 8.1', function (done) { var buildSpy = jasmine.createSpy(); createFindAllAvailableVersionsMock([{ version: '14.0', buildProject: buildSpy, path: testPath }]); @@ -337,7 +337,7 @@ describe('run method', function () { }); }); - xit('spec.13a should be able to override target via --appx parameter', function (done) { + it('spec.13a should be able to override target via --appx parameter', function (done) { var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) { // check that we build Windows 10 and not Windows 8.1 expect(solutionFile.toLowerCase()).toMatch('cordovaapp.windows10.jsproj'); @@ -354,7 +354,7 @@ describe('run method', function () { }); }); - xit('spec.13b should be able to override target via --appx parameter', function (done) { + it('spec.13b should be able to override target via --appx parameter', function (done) { var buildSpy = jasmine.createSpy().and.callFake(function (solutionFile, buildType, buildArch) { // check that we build Windows 10 and not Windows 8.1 expect(solutionFile.toLowerCase()).toMatch('cordovaapp.windows10.jsproj'); @@ -371,7 +371,7 @@ describe('run method', function () { }); }); - xit('spec.14 should use user-specified msbuild if VSINSTALLDIR variable is set', function (done) { + it('spec.14 should use user-specified msbuild if VSINSTALLDIR variable is set', function (done) { var customMSBuildPath = '/some/path'; var msBuildBinPath = path.join(customMSBuildPath, 'MSBuild/15.0/Bin'); var customMSBuildVersion = '15.0'; @@ -396,7 +396,7 @@ describe('run method', function () { }); }); - xit('spec.15a should choose latest version if there are multiple versions available with minor version difference', function (done) { + it('spec.15a should choose latest version if there are multiple versions available with minor version difference', function (done) { var fail = jasmine.createSpy('fail'); var buildTools14 = { version: '14.0', buildProject: jasmine.createSpy('buildTools14'), path: testPath }; var buildTools15 = { version: '15.0', buildProject: jasmine.createSpy('buildTools15'), path: testPath }; @@ -413,7 +413,7 @@ describe('run method', function () { }); }); - xit('spec.15b should choose latest version if there are multiple versions available with minor version difference', function (done) { + it('spec.15b should choose latest version if there are multiple versions available with minor version difference', function (done) { var fail = jasmine.createSpy('fail'); var buildTools14 = { version: '14.0', buildProject: jasmine.createSpy('buildTools14'), path: testPath }; var buildTools15 = { version: '15.0', buildProject: jasmine.createSpy('buildTools15'), path: testPath }; @@ -470,7 +470,7 @@ describe('buildFlags', function () { }); }); - xit('should pass buildFlags directly to MSBuild', function (done) { + it('should pass buildFlags directly to MSBuild', function (done) { var fail = jasmine.createSpy('fail'); var buildTools = { version: '14.0', buildProject: jasmine.createSpy('buildProject').and.returnValue(Q()), path: testPath }; var buildOptions = { -- To stop receiving notification emails like this one, please contact jan...@apache.org. --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org