This is an automated email from the ASF dual-hosted git repository.

janpio pushed a commit to branch janpio-msbuild_cleanup2
in repository https://gitbox.apache.org/repos/asf/cordova-windows.git


The following commit(s) were added to refs/heads/janpio-msbuild_cleanup2 by 
this push:
     new c80bab8  document ugly hack for VS17 MSBuild selection
c80bab8 is described below

commit c80bab8c9e9bd62459a6db30b0c20d028d8d224c
Author: Jan Piotrowski <piotrow...@gmail.com>
AuthorDate: Thu Feb 15 15:54:58 2018 +0100

    document ugly hack for VS17 MSBuild selection
---
 template/cordova/lib/MSBuildTools.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/template/cordova/lib/MSBuildTools.js 
b/template/cordova/lib/MSBuildTools.js
index b694fe9..fa05e73 100644
--- a/template/cordova/lib/MSBuildTools.js
+++ b/template/cordova/lib/MSBuildTools.js
@@ -150,6 +150,7 @@ function checkMSBuildVersion (version) {
     // console.log('correspondingWillows', correspondingWillows);
     var correspondingWillow = correspondingWillows[0]; // TODO Do not only 
handle one!
     if (correspondingWillow) {
+        // super hacky: VS2017/Willow is 15.x but MSBuild is always 15.0 in 
path - so set that here
         version = '15.0';
         var toolsPath = path.join(correspondingWillow.path, 'MSBuild', 
version, 'Bin');
         console.log('matching VS:', version, toolsPath);

-- 
To stop receiving notification emails like this one, please contact
jan...@apache.org.

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to