Menardi opened a new pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456 <!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected Android ### What does this PR do? Adds more unit tests for Android. Since my last PR adding tests went well, I decided to add some more. I have basically gone alphabetically and added tests to give full coverage for `Adb.js` and `AndroidManifest.js`. I may have time later in the next few days to add more tests, but I didn't want to make a huge PR which would take a long time to review. I also made a small change to the tests for `Api.js`. These tests previously logged `Android Studio project detected`, polluting the test reporter's output. They now no longer do this. I know the contribution guidelines say to squash PRs into one commit, but in this case, I believe the separate commits make sense. I suppose this could be two (or three) separate PRs. If I should do that next time, please let me know. ### What testing has been done on this change? Run `npm run unit-tests` locally ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
