wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406176669 Thanks for testing. Apparently I didn't test it enough, sorry. Still, for me it works on iOS, except that sometimes the alert _Result verified_ is shown twice. That is because, apparently, the loadstop event is being fired for customscheme as well. I don't see how that can be avoided, as in [`webViewDidFinishLoad`](https://github.com/apache/cordova-plugin-inappbrowser/blob/9cc7f69625363de9872f9dbc028b739f195a4f93/src/ios/CDVInAppBrowser.m#L463) (nor the [originating method](https://github.com/apache/cordova-plugin-inappbrowser/blob/9cc7f69625363de9872f9dbc028b739f195a4f93/src/ios/CDVInAppBrowser.m#L946)) there is no context about the URL that caused it. My proposal: 1. Mention `loadstop` being called for `customscheme` in the documentation (an extra `iOS quirks` in [addEventListener](https://github.com/apache/cordova-plugin-inappbrowser#inappbrowseraddeventlistener)). 2. In the test, only navigate to the custom URL at the first time it happens.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
