janpio commented on issue #563: [Fix] better support to find Home path for window URL: https://github.com/apache/cordova-android/pull/563#issuecomment-439701170 So your issue is that you develop your app on different computers. To be able to use the same `build.json` on all machines, you used `~` in the path to the keystore - but this didn't work as `HOME` was not correctly set on some machines. Is that correct? And to "fix" that, you now implemented this PR that allows the usage of `$HOME`, `%HOMEPATH%` and `%USERPROFILE%` instead of only `~` in the path of the keystore. But doesn't this still mean that all computer using the build.json still have to have exactly one of those environment variables set to work? Wouldn't it make more sense to try to replace `~` with all those environment variables, whichever are available instead of just offering alternatives?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
