mosabab removed a comment on issue #171: [do not merge yet](android) Read config.xml for statusbar overlay preference URL: https://github.com/apache/cordova-plugin-statusbar/pull/171#issuecomment-570937670 > @jcesarmobile I added the default preference so it is consistent with iOS. > > Do note though that on Android, the method expects you to supply a default value parameter, so that is left unchanged. So it does make it a little weird, having two sources of default values, with the one for android will obviously be never used and I think it makes it a bit more confusing. If we wanted to make this as consistent as iOS as possible, [CordovaPreferences](https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaPreferences.java) class would have to be changed, which would obviously be out of scope of this PR. > > Please do tell me what you think. You may also need to add `<preference name="StatusBarStyle" value="lightcontent" />` after your last change, as in iOS.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
