breautek commented on issue #171: Added ANDROID_GPS_REQUIRED parameter for optional GPS URL: https://github.com/apache/cordova-plugin-geolocation/pull/171#issuecomment-571227030 > Apps become available to non GPS hardware on Android, thats the change. It's a breaking change because required is currently implicit and existing apps may expect that behaviour. So by making the default to `false`, apps that were once "required gps" will now start appearing on app stores for devices with no GPS hardware. This would be an unexpected change in a patch/minor version bump, and a very dangerous mistake to make if one doesn't catch the change of behaviour as you cannot easily revoke a version of an app from the app store. > Apps are already available to non GPS hardware on iOS with this plugin, ie iPod Touch. This PR doesn't really have anything to do with iOS, and I'm not sure if iOS has an equivalent feature? If so, we can look at making sure it is consistent, but if current iOS apps has behaviour as GPS not required, then I would favour making it default `false` for the iOS platform and Android can be corrected to the same default in the next major release. > You are never guaranteed location data in you app anyway, as it might be disabled by the user. This is a different subject. There is a difference between an app requiring gps hardware and whether or not the app can receive gps events. Requiring GPS hardware means the app is absolutely useless without GPS hardware, so why give the option to the user to install the app? On the latter, the app can handle permission issues or whether GPS is enabled or not and give the appropriate feedback to the user. > If its deemed breaking, I still think false should be default, but of course the plugin would need a major version bump. In the end, I agree the default should be `false`, but the next release target is a patch update. So I would rather set the default to `true` now and expose the flag. Then look at changing the default in a major release, assuming the community agrees that the flag should be defaulted to `false` > Im not trying to be rude, just getting my opinion across. :) Opinions is always welcome :) Sometimes it is easy to misunderstand one intention as we are missing some very important communication tools... body language and tone of voice.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
