timbru31 commented on a change in pull request #634: (android) Added option to
turn on/off fullscreen mode in Android
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/634#discussion_r393932004
##########
File path: src/android/InAppBrowser.java
##########
@@ -147,6 +148,7 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean showFooter = false;
private String footerColor = "";
private String beforeload = "";
+ private boolean fullscreen = false;
Review comment:
@breautek @NiklasMerz - what's your opinion on this? It seems v3.1.0
accidentally sneaked in this breaking change (see, e.g.
https://github.com/apache/cordova-plugin-inappbrowser/issues/598#issuecomment-572597994)
Should we (a) restore v3.0.0 behavior or (b) follow semver and make it
configurable in a minor release?
The change to always full screen is now live since Jun 28, 2019, so nearly
two years.
Personally I'd vote for b)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
