j--w opened a new issue #652: window.handleOpenURL is triggered in WKWebView for system browser calls URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/652 # Bug Report When triggering a url to open in the `_system` browser through IAB with WKWebView window.handleOpenURL is called. If using UIWebView this does not happen. This appears to be a regression as this [issue](https://issues.apache.org/jira/browse/CB-14234) was fixed with [this PR](https://github.com/apache/cordova-plugin-inappbrowser/pull/278) but it appears the check never made it into [CDVWKInAppBrowser.m](https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/ios/CDVWKInAppBrowser.m#L360) ## Problem I believe there should be a check around the postNotification eg: `if ([[UIApplication sharedApplication] openURL:url] == NO)` ### What is expected to happen? window.handleOpenURL is not called ### What does actually happen? window.handleOpenURL is not called ## Information <!-- Include all relevant information that might help understand and reproduce the problem --> ### Command or Code I created a repo to reproduce https://github.com/j--w/iab-handleopenurl-bug/blob/master/www/js/index.js#L30 ### Environment, Platform, Device <!-- In what environment, on what platform or on which device are you experiencing the issue? --> ### Version information Cordova CLI: 7.1.0 Cordova IOS: 5.1.1 XCode 11.2.1 Cordova InAppBrowser 3.2.0 OSX ## Checklist <!-- Please check the boxes by putting an x in the [ ] like so: [x] --> - [X] I searched for existing GitHub issues - [X] I updated all Cordova tooling to most recent version - [X ] I included all the necessary information above
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org For additional commands, e-mail: commits-h...@cordova.apache.org
