[cordova-ios] branch master updated: feat(versions): print error messages, not error objects (#1186)

[raphinesse]

This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-ios.git


The following commit(s) were added to refs/heads/master by this push:
     new daee863  feat(versions): print error messages, not error objects 
(#1186)
daee863 is described below

commit daee863f9ad06151ca76e3f8b5671140addda6fd
Author: Raphael von der Grün <raphine...@gmail.com>
AuthorDate: Tue Nov 9 08:26:06 2021 +0100

    feat(versions): print error messages, not error objects (#1186)
    
    * refactor(versions): reject with error, not string
    * feat(versions): print error messages, not error objects
---
 bin/templates/scripts/cordova/lib/versions.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/bin/templates/scripts/cordova/lib/versions.js 
b/bin/templates/scripts/cordova/lib/versions.js
index 4c100d0..9e79f9b 100644
--- a/bin/templates/scripts/cordova/lib/versions.js
+++ b/bin/templates/scripts/cordova/lib/versions.js
@@ -49,9 +49,9 @@ exports.get_apple_xcode_version = () => {
     return spawn('xcodebuild', ['-version'])
         .then(output => {
             const versionMatch = /Xcode (.*)/.exec(output);
-
-            if (!versionMatch) return Promise.reject(output);
-
+            if (!versionMatch) {
+                throw new CordovaError('Could not determine Xcode version from 
output:\n' + output);
+            }
             return versionMatch[1];
         });
 };
@@ -124,7 +124,7 @@ exports.printOrDie = versionName =>
             console.log(version);
         },
         err => {
-            console.error(err);
+            console.error(err.message);
             process.exit(2);
         }
     );

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org