This is an automated email from the ASF dual-hosted git repository.
normanbreau pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-android.git
The following commit(s) were added to refs/heads/master by this push:
new 5b546a27 deprecate: CoreAndroid.getBuildConfigValue (#1597)
5b546a27 is described below
commit 5b546a27e62ec9c5569353fff8661361236cdb95
Author: Norman Breau <nor...@nbsolutions.ca>
AuthorDate: Fri Apr 14 10:15:09 2023 -0300
deprecate: CoreAndroid.getBuildConfigValue (#1597)
---
framework/src/org/apache/cordova/CoreAndroid.java | 29 ++++++-----------------
1 file changed, 7 insertions(+), 22 deletions(-)
diff --git a/framework/src/org/apache/cordova/CoreAndroid.java
b/framework/src/org/apache/cordova/CoreAndroid.java
index 6ebdecb3..ea04ca4d 100755
--- a/framework/src/org/apache/cordova/CoreAndroid.java
+++ b/framework/src/org/apache/cordova/CoreAndroid.java
@@ -19,6 +19,8 @@
package org.apache.cordova;
+import org.apache.cordova.BuildHelper;
+
import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;
@@ -30,7 +32,6 @@ import android.content.IntentFilter;
import android.telephony.TelephonyManager;
import android.view.KeyEvent;
-import java.lang.reflect.Field;
import java.util.HashMap;
/**
@@ -376,35 +377,19 @@ public class CoreAndroid extends CordovaPlugin {
}
}
- /*
+ /*
* This needs to be implemented if you wish to use the Camera Plugin or
other plugins
* that read the Build Configuration.
*
* Thanks to Phil@Medtronic and Graham Borland for finding the answer and
posting it to
* StackOverflow. This is annoying as hell!
*
+ * @deprecated Use {@link BuildHelper#getBuildConfigValue} instead.
*/
-
+ @Deprecated
public static Object getBuildConfigValue(Context ctx, String key)
{
- try
- {
- Class<?> clazz =
Class.forName(ctx.getClass().getPackage().getName() + ".BuildConfig");
- Field field = clazz.getField(key);
- return field.get(null);
- } catch (ClassNotFoundException e) {
- LOG.d(TAG, "Unable to get the BuildConfig, is this built with
ANT?");
- e.printStackTrace();
- } catch (NoSuchFieldException e) {
- LOG.d(TAG, key + " is not a valid field. Check your build.gradle");
- } catch (IllegalAccessException e) {
- LOG.d(TAG, "Illegal Access Exception: Let's print a stack trace.");
- e.printStackTrace();
- } catch (NullPointerException e) {
- LOG.d(TAG, "Null Pointer Exception: Let's print a stack trace.");
- e.printStackTrace();
- }
-
- return null;
+ LOG.w(TAG, "CoreAndroid.getBuildConfigValue is deprecated and will be
removed in a future release. Use BuildHelper.getBuildConfigValue instead.");
+ return BuildHelper.getBuildConfigValue(ctx, key);
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org
