Repository: couchdb-fauxton Updated Branches: refs/heads/master e508dad3e -> 13b760b41
Improving robustness of bulkDelete.js This test has been known to fail. This slows it down a bit to ensure elements are present and visible before they are clicked. I was able to see this test fail locally; this has fixed it for me. Project: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/repo Commit: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/commit/13b760b4 Tree: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/tree/13b760b4 Diff: http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/diff/13b760b4 Branch: refs/heads/master Commit: 13b760b4187a235f260907696405f22268b4ed2e Parents: e508dad Author: Ben Keen <[email protected]> Authored: Thu May 14 15:22:02 2015 -0700 Committer: Ben Keen <[email protected]> Committed: Thu May 14 16:17:32 2015 -0700 ---------------------------------------------------------------------- .../documents/tests/nightwatch/bulkDelete.js | 36 ++++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/couchdb-fauxton/blob/13b760b4/app/addons/documents/tests/nightwatch/bulkDelete.js ---------------------------------------------------------------------- diff --git a/app/addons/documents/tests/nightwatch/bulkDelete.js b/app/addons/documents/tests/nightwatch/bulkDelete.js index 333a8c4..57676a5 100644 --- a/app/addons/documents/tests/nightwatch/bulkDelete.js +++ b/app/addons/documents/tests/nightwatch/bulkDelete.js @@ -14,10 +14,10 @@ module.exports = { 'Bulk deletes': function (client) { var waitTime = client.globals.maxWaitTime, - newDatabaseName = client.globals.testDatabaseName, - newDocumentName1 = 'bulktest1', - newDocumentName2 = 'bulktest2', - baseUrl = client.globals.test_settings.launch_url; + newDatabaseName = client.globals.testDatabaseName, + newDocumentName1 = 'bulktest1', + newDocumentName2 = 'bulktest2', + baseUrl = client.globals.test_settings.launch_url; client .loginToGUI() @@ -25,18 +25,18 @@ module.exports = { .createDocument(newDocumentName2, newDatabaseName) .url(baseUrl + '/#/database/' + newDatabaseName + '/_all_docs') .waitForElementPresent('.control-toggle-alternative-header', waitTime, false) - .click('.control-toggle-alternative-header') + .clickWhenVisible('.control-toggle-alternative-header') .waitForElementPresent('.control-select-all', waitTime, false) - .click('.control-select-all') - .click('.control-delete') + .clickWhenVisible('.control-select-all', waitTime, false) + .clickWhenVisible('.control-delete', waitTime, false) .acceptAlert() .waitForElementVisible('#global-notifications .alert.alert-info', waitTime, false) .waitForElementNotPresent('[data-id="' + newDocumentName1 + '"]', waitTime, false) .getText('body', function (result) { var data = result.value, - isPresentFirstDoc = data.indexOf(newDocumentName1) !== -1, - isPresentSecondDoc = data.indexOf(newDocumentName2) !== -1, - bothMissing = !isPresentFirstDoc && !isPresentSecondDoc; + isPresentFirstDoc = data.indexOf(newDocumentName1) !== -1, + isPresentSecondDoc = data.indexOf(newDocumentName2) !== -1, + bothMissing = !isPresentFirstDoc && !isPresentSecondDoc; this.verify.ok(bothMissing, 'Checking if documents were deleted'); @@ -46,23 +46,23 @@ module.exports = { 'Select all works after changing the page': function (client) { var waitTime = client.globals.maxWaitTime, - newDatabaseName = client.globals.testDatabaseName, - baseUrl = client.globals.test_settings.launch_url; + newDatabaseName = client.globals.testDatabaseName, + baseUrl = client.globals.test_settings.launch_url; client .loginToGUI() .createManyDocuments(25, newDatabaseName) .url(baseUrl + '/#/database/' + newDatabaseName + '/_all_docs') .waitForElementPresent('.control-toggle-alternative-header', waitTime, false) - .click('.control-toggle-alternative-header') + .clickWhenVisible('.control-toggle-alternative-header') .waitForElementPresent('.control-select-all', waitTime, false) - .click('.control-select-all') - .waitForElementVisible('#next', waitTime, false) - .click('#next') + .clickWhenVisible('.control-select-all', waitTime, false) + .waitForElementPresent('#next', waitTime, false) + .clickWhenVisible('#next', waitTime, false) .waitForElementVisible('[data-id="27"]', waitTime, false) - .click('#previous') + .waitForElementPresent('#previous', waitTime, false) + .clickWhenVisible('#previous', waitTime, false) .waitForElementPresent('.control-select-all.js-headerbar-togglebutton-selected', waitTime, false) .end(); } - };
