This is an automated email from the ASF dual-hosted git repository.

jan pushed a commit to branch rebase/access-2023
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 2d6b377fc8e6947cf46d6acf49522d08ed0ca1d7
Author: Jan Lehnardt <[email protected]>
AuthorDate: Sat Aug 6 16:25:58 2022 +0200

    doc(access): add todos
---
 src/couch/src/couch_db.erl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/couch/src/couch_db.erl b/src/couch/src/couch_db.erl
index f0979d858..3454bc231 100644
--- a/src/couch/src/couch_db.erl
+++ b/src/couch/src/couch_db.erl
@@ -821,6 +821,7 @@ validate_access2(Db, Doc) ->
     validate_access3(check_access(Db, Doc)).
 
 validate_access3(true) -> ok;
+% TODO: fix language
 validate_access3(_) -> throw({forbidden, <<"can't touch this">>}).
 
 check_access(Db, #doc{access=Access}) ->
@@ -854,6 +855,7 @@ check_name(null, _Access) -> true;
 check_name(UserName, Access) ->
             lists:member(UserName, Access).
 % nicked from couch_db:check_security
+% TODO: might need DRY
 
 check_roles(Roles, Access) ->
     UserRolesSet = ordsets:from_list(Roles),

Reply via email to