This is an automated email from the ASF dual-hosted git repository.

nickva pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/couchdb-jiffy.git

commit 4c4cf905a1f2885cf42d3dea7f43d6757b508f72
Author: Nick Vatamaniuc <[email protected]>
AuthorDate: Mon Apr 13 17:38:10 2026 -0400

    Optimize termstack_restore allocation
    
    When we restore try to get back to the memory size we had before instead of
    always doubling
    
    h/t to @davisp for spotting this one
---
 c_src/encoder.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/c_src/encoder.c b/c_src/encoder.c
index cd41d35..310ebe2 100644
--- a/c_src/encoder.c
+++ b/c_src/encoder.c
@@ -84,14 +84,20 @@ termstack_restore(ErlNifEnv* env, ERL_NIF_TERM from, 
TermStack* stack)
     int arity;
 
     if(enif_get_tuple(env, from, &arity, &elements)) {
+        assert(arity > 0 && "Erlang bug: enif_get_tuple returned a negative 
arity");
+
         stack->top = arity;
 
         if(arity <= SMALL_TERMSTACK_SIZE) {
             stack->elements = &stack->__default_elements[0];
             stack->size = SMALL_TERMSTACK_SIZE;
         } else {
-            stack->size = arity * 2;
-            stack->elements = enif_alloc(stack->size * sizeof(ERL_NIF_TERM));
+            size_t size = SMALL_TERMSTACK_SIZE;
+            while(size < stack->top) {
+                size *= 2;
+            }
+            stack->size = size;
+            stack->elements = enif_alloc(size * sizeof(ERL_NIF_TERM));
 
             if(!stack->elements) {
                 return 0;

Reply via email to