This is an automated email from the ASF dual-hosted git repository. pottlinger pushed a commit to branch feature/RAT-369 in repository https://gitbox.apache.org/repos/asf/creadur-rat.git
commit 39cb8b14b63abd4a11981fc0242638d7d99d199c Author: P. Ottlinger <pottlin...@apache.org> AuthorDate: Sun Apr 21 23:10:36 2024 +0200 RAT-369: Tweak config and add exclusion files in submodules --- apache-rat-core/spotbugs_ignore.xml | 27 +++++++++++++++++++++++++++ apache-rat-plugin/spotbugs_ignore.xml | 27 +++++++++++++++++++++++++++ apache-rat-tasks/spotbugs_ignore.xml | 27 +++++++++++++++++++++++++++ pom.xml | 4 +++- 4 files changed, 84 insertions(+), 1 deletion(-) diff --git a/apache-rat-core/spotbugs_ignore.xml b/apache-rat-core/spotbugs_ignore.xml new file mode 100644 index 00000000..f6a55af9 --- /dev/null +++ b/apache-rat-core/spotbugs_ignore.xml @@ -0,0 +1,27 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <!-- Uses tryWithResources, thus closes resource properly: + [ERROR] Medium: org.apache.rat.configuration.builders.ChildContainerBuilder.setResource(String) may fail to close stream + [org.apache.rat.configuration.builders.ChildContainerBuilder] At ChildContainerBuilder.java:[line 62] OS_OPEN_STREAM + --> + <Class name="org.apache.rat.configuration.builders.ChildContainerBuilder"/> + <Bug pattern="OS_OPEN_STREAM"/> + </Match> +</FindBugsFilter> diff --git a/apache-rat-plugin/spotbugs_ignore.xml b/apache-rat-plugin/spotbugs_ignore.xml new file mode 100644 index 00000000..f6a55af9 --- /dev/null +++ b/apache-rat-plugin/spotbugs_ignore.xml @@ -0,0 +1,27 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <!-- Uses tryWithResources, thus closes resource properly: + [ERROR] Medium: org.apache.rat.configuration.builders.ChildContainerBuilder.setResource(String) may fail to close stream + [org.apache.rat.configuration.builders.ChildContainerBuilder] At ChildContainerBuilder.java:[line 62] OS_OPEN_STREAM + --> + <Class name="org.apache.rat.configuration.builders.ChildContainerBuilder"/> + <Bug pattern="OS_OPEN_STREAM"/> + </Match> +</FindBugsFilter> diff --git a/apache-rat-tasks/spotbugs_ignore.xml b/apache-rat-tasks/spotbugs_ignore.xml new file mode 100644 index 00000000..f6a55af9 --- /dev/null +++ b/apache-rat-tasks/spotbugs_ignore.xml @@ -0,0 +1,27 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<FindBugsFilter> + <Match> + <!-- Uses tryWithResources, thus closes resource properly: + [ERROR] Medium: org.apache.rat.configuration.builders.ChildContainerBuilder.setResource(String) may fail to close stream + [org.apache.rat.configuration.builders.ChildContainerBuilder] At ChildContainerBuilder.java:[line 62] OS_OPEN_STREAM + --> + <Class name="org.apache.rat.configuration.builders.ChildContainerBuilder"/> + <Bug pattern="OS_OPEN_STREAM"/> + </Match> +</FindBugsFilter> diff --git a/pom.xml b/pom.xml index 471ec421..597961d5 100644 --- a/pom.xml +++ b/pom.xml @@ -308,7 +308,9 @@ agnostic home for software distribution comprehension and audit tools. <configuration> <!-- TODO remove after RAT-369 is done --> <failOnError>false</failOnError> - <excludeFilterFile>spotbugs-ignore.xml</excludeFilterFile> + <!-- we only want to see our own problems --> + <onlyAnalyze>org.apache.rat.*</onlyAnalyze> + <excludeFilterFile>${basedir}/spotbugs_ignore.xml</excludeFilterFile> <plugins> <plugin> <groupId>com.h3xstream.findsecbugs</groupId>