[GitHub] [curator] kezhuw commented on a diff in pull request #454: CURATOR-666: Fix twice unfixForNamespace in background create

[via GitHub]

kezhuw commented on code in PR #454:
URL: https://github.com/apache/curator/pull/454#discussion_r1157308301


##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java:
##########
@@ -797,7 +797,7 @@ public void performBackgroundOperation(OperationAndData<T> 
dummy) throws Excepti
                 {
                     if ( 
!client.getZookeeperClient().getRetryPolicy().allowRetry(e) )
                     {
-                        final CuratorEvent event = makeCuratorEvent(client, 
e.code().intValue(), e.getPath(), null, e.getPath(), null);

Review Comment:
   I changed the `throw e` to `return` in latest push. I think it is 
unnecessary to report or log such exception as un-handled now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org