[GitHub] [curator] Ryan0751 commented on a diff in pull request #396: CURATOR-609 - ModeledCache attempts to deserialize empty ZNodes on deletion, resulting in exceptions

[via GitHub]

Ryan0751 commented on code in PR #396:
URL: https://github.com/apache/curator/pull/396#discussion_r1161907098


##########
curator-x-async/src/test/java/org/apache/curator/x/async/modeled/TestModeledFrameworkBase.java:
##########
@@ -48,8 +50,8 @@ public void setup() throws Exception
         rawClient.start();
         async = AsyncCuratorFramework.wrap(rawClient);
 
-        JacksonModelSerializer<TestModel> serializer = 
JacksonModelSerializer.build(TestModel.class);
-        JacksonModelSerializer<TestNewerModel> newSerializer = 
JacksonModelSerializer.build(TestNewerModel.class);
+        serializer = JacksonModelSerializer.build(TestModel.class);

Review Comment:
   I made these protected members of TestModeledFrameworkBase so that I didn't 
have to redefine the serializer in the added tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org