tisonkun commented on code in PR #460:
URL: https://github.com/apache/curator/pull/460#discussion_r1199691448
##########
curator-framework/src/main/java/org/apache/curator/framework/imps/EnsembleTracker.java:
##########
@@ -209,10 +209,17 @@ private void processConfigData(byte[] data) throws
Exception
if (!properties.isEmpty())
{
QuorumMaj newConfig = new QuorumMaj(properties);
- String connectionString = configToConnectionString(newConfig);
- if (connectionString.trim().length() > 0)
+ String connectionString =
configToConnectionString(newConfig).trim();
+ if (!connectionString.isEmpty())
{
currentConfig.set(newConfig);
+ String oldConnectionString =
ensembleProvider.getConnectionString();
+ int i = oldConnectionString.indexOf('/');
+ if (i >= 0)
Review Comment:
Perhap `== 0`? I'm not sure when `i > 0` if it's an error state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
