kezhuw commented on code in PR #478:
URL: https://github.com/apache/curator/pull/478#discussion_r1311375125
##########
curator-recipes/src/main/java/org/apache/curator/framework/recipes/shared/SharedValue.java:
##########
@@ -196,7 +196,7 @@ public boolean trySetValue(VersionedValue<byte[]> previous,
byte[] newValue) thr
private void updateValue(int version, byte[] bytes) {
while (true) {
VersionedValue<byte[]> current = currentValue.get();
- if (current.getVersion() >= version) {
+ if (current.getVersion() >= version && version !=
Integer.MIN_VALUE) {
Review Comment:
Sound reasonable circumvent. But when `current.getVersion()` reach `-1`, the
next `trySetCount` is indeterminate.
And absolutely, we should document a bit, either this wraparound and
indeterminate in `-1` or old behavior. I even think whether an exception is
more appropriate ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
