chevaris commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2025095911


##########
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##########
@@ -187,4 +187,34 @@ public void childEvent(CuratorFramework client, 
PathChildrenCacheEvent event) th
             assertNull(client.checkExists().forPath("/test"));
         }
     }
+
+    @Test
+    public void testTouchNodeNotCreated() throws Exception {
+        try (CuratorFramework client =
+                CuratorFrameworkFactory.newClient(server.getConnectString(), 
new RetryOneTime(1))) {
+            client.start();
+            final long ttlMs = 1_000L;
+            try (PersistentTtlNode node = new PersistentTtlNode(client, 
"/test", ttlMs, new byte[0])) {
+                node.start();
+                assertTrue(node.waitForInitialCreate(timing.session(), 
TimeUnit.MILLISECONDS));
+                // Give some minor time for touch node to be created. Will 
worked after patch

Review Comment:
   I provided a new implementation with a new approach that is much more 
accurate in the second commit. Basically I will watch all lifecycle for main 
and  touch nodes with PersistentWatch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to