kotman12 commented on PR #1257: URL: https://github.com/apache/curator/pull/1257#issuecomment-2752607147
@kezhuw thanks! A few observations here: `CachedModeledFramework::list` indeed ignores data hierarchy and returns all descendants of the base path but this is consistent with the [API doc](https://curator.apache.org/apidocs/org/apache/curator/x/async/modeled/cached/CachedModeledFramework.html#list()) (as well as previous behavior): > Return the instances of the base path of this cached framework Is your suggestion to add the word "recursively" to the doc somewhere in `ModeledCache::currentChildren` and `CachedModeledFramework::list` to stress that it recursively returns children's children? My immediate word of choice is "descendant" but I don't see it used anywhere in the curator docs so I don't want to introduce new terminology. Tangentially, something I found strange is that `CachedModeledFramework::parent` is unimplemented but you can still potentially get the parent's modeled _data_ if it is under the cache's base path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@curator.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
