fapifta commented on code in PR #1278:
URL: https://github.com/apache/curator/pull/1278#discussion_r2334227217
##########
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java:
##########
@@ -383,6 +385,16 @@ public void close() {
}
}
+ if (!isExternalRunSafeService) {
+ ((ExecutorService) runSafeService).shutdownNow();
+ try {
+ ((ExecutorService)
runSafeService).awaitTermination(maxCloseWaitMs, TimeUnit.MILLISECONDS);
Review Comment:
Yes, you are right, I have changed the approach to ensure we have wait until
maxCloseWaitMs for both executor in parallel. Should I add a test for that also
what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
