Repository: cxf
Updated Branches:
  refs/heads/3.1.x-fixes 0ba04d859 -> 3c788423d


Fix to the oidc registration service


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/3c788423
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/3c788423
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/3c788423

Branch: refs/heads/3.1.x-fixes
Commit: 3c788423d2da7b3ed103b1b3b225b31517660049
Parents: 0ba04d8
Author: Sergey Beryozkin <[email protected]>
Authored: Mon Feb 27 16:29:43 2017 +0000
Committer: Sergey Beryozkin <[email protected]>
Committed: Mon Feb 27 16:32:21 2017 +0000

----------------------------------------------------------------------
 .../oidc/idp/OidcDynamicRegistrationService.java     | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/3c788423/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
----------------------------------------------------------------------
diff --git 
a/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
 
b/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
index 2e6b462..c2ce9df 100644
--- 
a/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
+++ 
b/rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcDynamicRegistrationService.java
@@ -49,7 +49,12 @@ public class OidcDynamicRegistrationService extends 
DynamicRegistrationService {
     
     @Override
     protected ClientRegistrationResponse 
fromClientToRegistrationResponse(Client client) {
-        ClientRegistrationResponse resp = 
super.fromClientToRegistrationResponse(client);
+        return super.fromClientToRegistrationResponse(client);
+    }
+
+    @Override
+    protected ClientRegistration fromClientToClientRegistration(Client client) 
{
+        ClientRegistration resp = super.fromClientToClientRegistration(client);
         String logoutUris = 
client.getProperties().get(RP_INITIATED_LOGOUT_URIS);
         if (logoutUris != null) {
             List<String> list = new LinkedList<String>();
@@ -60,13 +65,7 @@ public class OidcDynamicRegistrationService extends 
DynamicRegistrationService {
         }
         return resp;
     }
-    
-    @Override
-    protected ClientRegistration fromClientToClientRegistration(Client client) 
{
-        //TODO: check OIDC specific properties in Client extra properties
-        return super.fromClientToClientRegistration(client);
-    }
-    
+
     protected int getClientSecretSizeInBytes(ClientRegistration request) {
            
         // TODO: may need to be 384/8 or 512/8 if not a default HS256 but 
HS384 or HS512

Reply via email to